gemmellr commented on code in PR #5477: URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934142083
########## artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java: ########## @@ -111,14 +108,13 @@ public static Object[] fromJsonArray(final JsonArray jsonArray) throws Exception } array[i] = map; - } else if (val instanceof JsonString) { - array[i] = ((JsonString) val).getString(); + } else if (val instanceof JsonString string) { + array[i] = string.getString(); Review Comment: I'm giving up looking at the rest of the json stuff...same type of recent comments+suggestions to make it more readable than originally, rather than arguably less readable, also apply to the rest of it as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact