gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934153156
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java:
##########
@@ -961,9 +960,9 @@ private int getConnectionWithRetry(final int
reconnectAttempts, RemotingConnecti
}
if (getConnection() != null) {
- if (oldConnection != null && oldConnection instanceof
CoreRemotingConnection) {
+ if (oldConnection != null && oldConnection instanceof
CoreRemotingConnection remotingConnection) {
Review Comment:
**old**RemotingConnection would be more readable, given its used on the same
line as the new CoreRemotingConnection _connection_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
