gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934147944
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/TransportConfiguration.java:
##########
@@ -328,18 +328,18 @@ private void encodeMap(final ActiveMQBuffer buffer, final
Map<String, Object> ma
Object val = entry.getValue();
- if (val instanceof Boolean) {
+ if (val instanceof Boolean boolean1) {
Review Comment:
booleanVal / longVal / etc style naming or similar , or just leaving the
casts, would be more nicer to read later than than boolean1 etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
