gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934307148
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ActiveMQAbstractView.java:
##########
@@ -116,11 +116,11 @@ public Comparator<T> getComparator() {
try {
Object leftValue = getField(left, sortField);
Object rightValue = getField(right, sortField);
- if (leftValue instanceof Comparable && rightValue instanceof
Comparable) {
+ if (leftValue instanceof Comparable comparable && rightValue
instanceof Comparable comparable1) {
Review Comment:
Better names would help here...without them, the code below is far more
readable as it was than it is after this adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
