gemmellr commented on code in PR #5477: URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934317129
########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java: ########## @@ -3717,8 +3717,8 @@ private RoutingStatus move(final Transaction originalTX, Message copyMessage = makeCopy(ref, reason == AckReason.EXPIRED, address); Object originalRoutingType = ref.getMessage().getBrokerProperty(Message.HDR_ORIG_ROUTING_TYPE); - if (originalRoutingType != null && originalRoutingType instanceof Byte) { - copyMessage.setRoutingType(RoutingType.getType((Byte) originalRoutingType)); + if (originalRoutingType != null && originalRoutingType instanceof Byte byte1) { + copyMessage.setRoutingType(RoutingType.getType(byte1)); Review Comment: ```suggestion if (originalRoutingType != null && originalRoutingType instanceof Byte origRoutingType) { copyMessage.setRoutingType(RoutingType.getType(origRoutingType)); ``` Similarly below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact