gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934293241
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java:
##########
@@ -216,8 +216,8 @@ public static org.apache.activemq.artemis.api.core.Message
inbound(final Message
}
final Object scheduledDelay =
messageSend.getProperties().get(ScheduledMessage.AMQ_SCHEDULED_DELAY);
- if (scheduledDelay instanceof Long) {
-
coreMessage.putLongProperty(org.apache.activemq.artemis.api.core.Message.HDR_SCHEDULED_DELIVERY_TIME,
System.currentTimeMillis() + ((Long) scheduledDelay));
+ if (scheduledDelay instanceof Long long1) {
Review Comment:
Something like delayMs or delayLong would be far more readable later.
Just about every name added below is equally unhelpful, and results in less
readable code than the original.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
