jbertram commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934576741
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncJournalTest.java:
##########
@@ -154,14 +154,9 @@ public void testReserveFileIdValuesOnBackup() throws
Exception {
assertEquals(size, backupMsgJournal.getFileSize(), "file sizes must be
the same");
Set<Pair<Long, Integer>> backupIds = getFileIds(backupMsgJournal);
-
- int total = 0;
for (Pair<Long, Integer> pair : primaryIds) {
- total += pair.getB();
Review Comment:
Fixed.
##########
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/JournaHistorylBackupTest.java:
##########
@@ -125,11 +126,11 @@ public void removeBKPExtension() throws Throwable {
String withBKP = withoutBkp + ".bkp";
// I was actually born at 4:30 :) but I need all numbers lower than 2
digits on the test
assertEquals(withoutBkp, journal.removeBackupExtension(withBKP));
- assertEquals(withoutBkp, journal.removeBackupExtension(withoutBkp)); //
it should be possible to do it
-
- String withoutBKP = "jrn-1.data";
+ assertEquals(withoutBkp, journal.removeBackupExtension(withoutBkp));
}
+ // it should be possible to do it
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
