jbertram commented on code in PR #5477: URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934600372
########## artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java: ########## @@ -96,9 +94,6 @@ public class ActiveMQConnectionFactory extends JNDIStorable implements Connectio private boolean cacheDestinations; - // keeping this field for serialization compatibility only. do not use it - private boolean finalizeChecks; Review Comment: Also left this one alone as well. ########## artemis-jms-client/src/main/java/org/apache/activemq/artemis/jndi/ActiveMQInitialContextFactory.java: ########## Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact