jbertram commented on code in PR #5533:
URL: https://github.com/apache/activemq-artemis/pull/5533#discussion_r1977783456
##########
artemis-server/pom.xml:
##########
@@ -156,6 +156,10 @@
<groupId>io.micrometer</groupId>
<artifactId>micrometer-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-boot</artifactId>
+ </dependency>
Review Comment:
I don't mean to sound like a broken record, but this seems inverted to me
like the issue with `artemis-commons` before. The `artemis-boot` module starts
the broker. It doesn't seem like the broker should depend up on it.
Have you considered moving the constant to `artemis-commons` and then making
`artemis-boot` depend on `artemis-commons` but excluding all the
`artemis-commons` dependencies so you don't get a bunch of transitive stuff?
Then the boot classpath can safely be `artemis-boot` and `artemis-commons`.
I also still think it would make sense just to ditch the constant altogether
and use the literal instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
