gtully commented on code in PR #5533:
URL: https://github.com/apache/activemq-artemis/pull/5533#discussion_r1977804103
##########
artemis-server/pom.xml:
##########
@@ -156,6 +156,10 @@
<groupId>io.micrometer</groupId>
<artifactId>micrometer-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-boot</artifactId>
+ </dependency>
Review Comment:
boot sets up and environment, and the broker makes use of that, it is
communicating via system properties and the constant captures that. I don't
want that env to change without reference to the shared usage. boot is
intentionally very small with no deps, it is a good thing to depend on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
