gtully commented on code in PR #5533: URL: https://github.com/apache/activemq-artemis/pull/5533#discussion_r1979812615
########## artemis-server/pom.xml: ########## @@ -156,6 +156,10 @@ <groupId>io.micrometer</groupId> <artifactId>micrometer-core</artifactId> </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-boot</artifactId> + </dependency> Review Comment: ok, boot cannot have any dep due to the class loader, but having an extra dep on server, for the embedded broker case may be a problem. I will revert the constant and follow the existing duplicated strings model -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact