jbertram commented on code in PR #5533:
URL: https://github.com/apache/activemq-artemis/pull/5533#discussion_r1977826541
##########
artemis-server/pom.xml:
##########
@@ -156,6 +156,10 @@
<groupId>io.micrometer</groupId>
<artifactId>micrometer-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-boot</artifactId>
+ </dependency>
Review Comment:
> I don't want that env to change without reference to the shared usage.
Maybe add a comment in the code referencing the shared usage?
That said, I'm not clear on why it's critical to link things together with a
constant like this in the first place. The fact that the constant alone doesn't
make it clear seems to push against the the idea that a constant is actually
necessary.
> boot is intentionally very small with no deps, it is a good thing to
depend on.
I agree that it is intentionally very small. That's because it has one very
specific job. I don't agree that necessarily makes it a good thing to depend
on. It's certainly convenient, but I don't think it's good in this instance.
> I think your original argument for not putting it is commons made sense...
I was actually arguing that the constant _should_ be in `artemis-commons`
and that `artemis-commons` shouldn't depend on `artemis-boot`. The same thing
applies here. Shared dependencies like this constant should be in
`artemis-commons`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
