gemmellr commented on code in PR #76:
URL: 
https://github.com/apache/activemq-artemis-console/pull/76#discussion_r2068328191


##########
artemis-console-extension/pom.xml:
##########
@@ -87,14 +87,21 @@
                 <configuration>
                     <filesets>
                         <fileset>
-                            
<directory>${basedir}/${extension.path}/build</directory>
+                            
<directory>${basedir}/${extension.path}/app/build</directory>

Review Comment:
   Give "mvn clean verify -Papache-release -Dgpg.skip" a run to produce the 
source release assembly, and I expect the archive will then includes this new 
_build_ dir and the other new _dist_ dir, and not include the deleted 
artemis-console-extension/artemis-extension/.yarn/releases/LICENSE-yarn.txt 
file that will still be referenced from the LICENCE file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to