grgrzybek commented on code in PR #76: URL: https://github.com/apache/activemq-artemis-console/pull/76#discussion_r2068332465
########## artemis-console-extension/pom.xml: ########## @@ -87,14 +87,21 @@ <configuration> <filesets> <fileset> - <directory>${basedir}/${extension.path}/build</directory> + <directory>${basedir}/${extension.path}/app/build</directory> Review Comment: I'm checking why `.yarn/releases/LICENSE-yarn.txt` was removed. I change the exclusion with: ``` diff --git a/artemis-console-distribution/src/main/assembly/source-assembly.xml b/artemis-console-distribution/src/main/assembly/source-assembly.xml index fb8dcf2..c4ee367 100644 --- a/artemis-console-distribution/src/main/assembly/source-assembly.xml +++ b/artemis-console-distribution/src/main/assembly/source-assembly.xml @@ -40,7 +40,8 @@ <!-- Yarn and NPM build dir --> <exclude>artemis-console-extension/artemis-extension/node/**</exclude> <exclude>artemis-console-extension/artemis-extension/node_modules/**</exclude> - <exclude>artemis-console-extension/artemis-extension/build/**</exclude> + <exclude>artemis-console-extension/artemis-extension/app/build/**</exclude> + <exclude>artemis-console-extension/artemis-extension/packages/artemis-console-plugin/dist/**</exclude> <exclude>artemis-console-extension/artemis-extension/.yarn/**</exclude> <!-- in case some of the build generates data, this needs to be ignored --> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact