tabish121 commented on code in PR #5715:
URL: https://github.com/apache/activemq-artemis/pull/5715#discussion_r2114260270
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java:
##########
@@ -1423,15 +1423,30 @@ default boolean isJDBC() {
* This is necessary because MQTT sessions and handled on a broker-wide
basis so this can't be set on a per-connector
* basis like most of the other MQTT-specific settings.
*/
Review Comment:
I was going to make a similar comment about the deprecation docs. We should
in general document what we intend as an alternative API call when deprecating
or indicate the deprecated options no longer have any side effect and are
essentially no-ops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
