clebertsuconic commented on code in PR #5715:
URL: https://github.com/apache/activemq-artemis/pull/5715#discussion_r2114260470


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##########
@@ -513,6 +513,8 @@ public void parseMainConfig(final Element e, final 
Configuration config) throws
 
       config.setMqttSessionStatePersistenceTimeout(getLong(e, 
"mqtt-session-state-persistence-timeout", 
config.getMqttSessionStatePersistenceTimeout(), GT_ZERO));

Review Comment:
   Can you add a log.warn here that this value is deprecated and no longer in 
use in case the XML is filled?.
   
   Or perhaps in the configurationImpl itself as it could been set by broker 
properties:
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to