clebertsuconic commented on code in PR #5715:
URL: https://github.com/apache/activemq-artemis/pull/5715#discussion_r2114296274


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5Test.java:
##########
@@ -871,4 +875,53 @@ public void testFlowControlAfterDisconnect() throws 
Exception {
       Wait.assertEquals(1L, () -> subscriptionQueue.getMessagesAcknowledged(), 
2000, 50);
       Wait.assertEquals(0L, () -> subscriptionQueue.getMessageCount(), 2000, 
50);
    }
+
+   /**
+    * This test helps validate that there are no longer timeouts related to 
persisting subscriptions under load.
+    * However, it is disabled because it takes a relatively long time to run. 
I'm leaving it here for ad hoc runs
+    * as necessary.
+    */
+   @Disabled
+   @Test
+   @Timeout(DEFAULT_TIMEOUT_SEC)
+   public void testLoadOnSubscriptionPersistence() throws Exception {

Review Comment:
   Can you make this test faster?
   
   I have a few SoakTests that will run faster than this one. it's taking 22 
seconds..
   
   You could perhaps limit the executor on a server and run less threads?
   
   
   At least make it into a SoakTest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to