clebertsuconic commented on code in PR #5715:
URL: https://github.com/apache/activemq-artemis/pull/5715#discussion_r2114301469
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5Test.java:
##########
@@ -871,4 +875,53 @@ public void testFlowControlAfterDisconnect() throws
Exception {
Wait.assertEquals(1L, () -> subscriptionQueue.getMessagesAcknowledged(),
2000, 50);
Wait.assertEquals(0L, () -> subscriptionQueue.getMessageCount(), 2000,
50);
}
+
+ /**
+ * This test helps validate that there are no longer timeouts related to
persisting subscriptions under load.
+ * However, it is disabled because it takes a relatively long time to run.
I'm leaving it here for ad hoc runs
+ * as necessary.
+ */
+ @Disabled
+ @Test
+ @Timeout(DEFAULT_TIMEOUT_SEC)
+ public void testLoadOnSubscriptionPersistence() throws Exception {
Review Comment:
BTW: if you decide to make it into SoakTEsts.. you don't necessarily need to
have a RealServer running.. YOu could still have the same test in the
soak-tests...
but ultimately it would just be better to make the test reproduce the issue
faster not requiring 20 seconds?
although I understand we need some balance between the time you take to make
the change..
(Like I'm exagerating of course but it takes 2 days to make the change
versus 20seconds * number of runs) then it's cheaper to use the CI's time..
but if it's a simple change it would be great to just make it faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
