mattrpav commented on code in PR #2755:
URL: https://github.com/apache/activemq/pull/2755#discussion_r4482281903
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -129,6 +129,7 @@ public class Queue extends BaseDestination implements Task,
UsageListener, Index
private MessageGroupMap messageGroupOwners;
private DispatchPolicy dispatchPolicy = new RoundRobinDispatchPolicy();
private MessageGroupMapFactory messageGroupMapFactory = new
CachedMessageGroupMapFactory();
+ private volatile boolean useMessageGroups = true;
Review Comment:
Good call. I think dropping volatile now makes sense. The primary runtime
use case for changing it would be to manually test. Changing the value wouldn't
fix a message group dead lock.
I'll flip off the volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact