mattrpav commented on code in PR #2755:
URL: https://github.com/apache/activemq/pull/2755#discussion_r4481871751


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -129,6 +129,7 @@ public class Queue extends BaseDestination implements Task, 
UsageListener, Index
     private MessageGroupMap messageGroupOwners;
     private DispatchPolicy dispatchPolicy = new RoundRobinDispatchPolicy();
     private MessageGroupMapFactory messageGroupMapFactory = new 
CachedMessageGroupMapFactory();
+    private volatile boolean useMessageGroups = true;

Review Comment:
   I believe volatile is correct (but this one isn't critical) since the value 
can be changed at runtime. Depends on _how_ immediate everyone expects each 
field. That rule could vary field-by-field, so I was thinking probably best to 
have it be volatile to signal that it changes at runtime, but the other option 
is to wait until the config refactor where we may do something like have a 
single config object carrying all config fields with one visibility concern vs 
all these individual fields each having their own visibility concern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to