cshannon commented on code in PR #2755:
URL: https://github.com/apache/activemq/pull/2755#discussion_r4481484517


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -129,6 +129,7 @@ public class Queue extends BaseDestination implements Task, 
UsageListener, Index
     private MessageGroupMap messageGroupOwners;
     private DispatchPolicy dispatchPolicy = new RoundRobinDispatchPolicy();
     private MessageGroupMapFactory messageGroupMapFactory = new 
CachedMessageGroupMapFactory();
+    private volatile boolean useMessageGroups = true;

Review Comment:
   i'm not sure if we need the volatile here, most other things do not use it 
when we update policies and we have lots of locks everywhere that the memory 
barrier might be fine. i would need to take a look closer but it would be a bit 
odd to mark this volatile, but then all the other variables are not. An example 
is strictOrderDispatch, if we need to mark this volatile than that should be 
volatile, etc. It's also possible that marking this volatile is correct and the 
others are wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to