jcamachor commented on a change in pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r332262473
 
 

 ##########
 File path: 
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 ##########
 @@ -667,6 +667,19 @@ public static ConfVars getMetaConf(String name) {
     RUNTIME_STATS_MAX_AGE("runtime.stats.max.age", 
"hive.metastore.runtime.stats.max.age", 86400 * 3, TimeUnit.SECONDS,
         "Stat entries which are older than this are removed."),
 
+    SCHEDULED_QUERIES_CRON_SYNTAX("scheduled.queries.cron.syntax", 
"hive.metastore.scheduled.queries.cron.syntax",
+        "QUARTZ", new StringSetValidator("UNIX", "QUARTZ", "CRON4J", "SPRING"),
 
 Review comment:
   Is there a good reason to support all these different syntax? I am thinking 
that maintaining / debugging them may become hard. I think we should stick to 
the most expressive one and support that one, unless there is some value on 
supporting all of them...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to