jcamachor commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337260931
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinConstraintsRule.java
 ##########
 @@ -117,7 +117,7 @@ public void onMatch(RelOptRuleCall call) {
     // These boolean values represent corresponding left, right input which is 
potential FK
     boolean leftInputPotentialFK = topRefs.intersects(leftBits);
     boolean rightInputPotentialFK = topRefs.intersects(rightBits);
-    if (leftInputPotentialFK && rightInputPotentialFK && joinType == 
JoinRelType.INNER) {
+    if (leftInputPotentialFK && rightInputPotentialFK && (joinType == 
JoinRelType.INNER || joinType == JoinRelType.SEMI)) {
 
 Review comment:
   Same comment for all rules that match on `HiveJoin` (this does not seem to 
be the case for this one).
   
   I am not trying to be picky, it is just that if we are not sure that these 
rules will work correctly, maybe we should bail out until we can add proper 
semijoin testing for them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to