jcamachor commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337267137
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
##########
@@ -100,7 +100,7 @@ public void onMatch(RelOptRuleCall call) {
// If it is not an inner join, we do not push the
// aggregate operator
- if (join.getJoinType() != JoinRelType.INNER) {
+ if (join.getJoinType() != JoinRelType.INNER && !join.isSemiJoin()) {
Review comment:
After this patch, this rule will work with semijoins (see L68 for the
matching). How difficult would be to add a test that that triggers this rule so
we can verify it is working as expected? Otherwise, maybe it is better to play
it safe and skip for semijoins for the time being.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
