jcamachor commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337262615
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java
 ##########
 @@ -118,7 +118,7 @@ protected void perform(final RelOptRuleCall call, final 
ImmutableBitSet topRefs,
       call.transformTo(topOperator.copy(topOperator.getTraitSet(), 
ImmutableList.of(left)));
       return;
     }
-    if (join.getJoinType() != JoinRelType.INNER) {
+    if (join.getJoinType() != JoinRelType.INNER && !join.isSemiJoin()) {
 
 Review comment:
   If this is already a semijoin, we should bail out immediately since this 
rule is trying to transform a join into a semijoin?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to