jcamachor commented on a change in pull request #812: Hive 22324 URL: https://github.com/apache/hive/pull/812#discussion_r337245837
########## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java ########## @@ -176,8 +187,7 @@ public RelNode createSemiJoin(RelNode left, RelNode right, RexNode condition) { final JoinInfo joinInfo = JoinInfo.of(left, right, condition); final RelOptCluster cluster = left.getCluster(); - return HiveSemiJoin.getSemiJoin(cluster, left.getTraitSet(), left, right, condition, - joinInfo.leftKeys, joinInfo.rightKeys); Review comment: Were leftKeys and rightKeys useless? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org