szlta commented on a change in pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389559046
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics,
ioMetrics, tracePool);
this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics,
tracePool) : null;
+ proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
Review comment:
Well I agree on the daemon side, but not on iHS2. I think this should not
handled the same way purge is:
- the invocation of purge is done by the users themselves so they should
know what they're doing and this can wait for the result however long it takes
- proactive eviction is done in the background i.e. less apparent to the
users - e.g. whenever a drop table/partition/db happens. I'd imagine a use case
where we have many many daemons with large caches, and such proactive eviction
could take longer. In this case I don't want users having to wait for the
eviction to complete before their drop table command returns.
Wouldn't you agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
