szlta commented on a change in pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389787317
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics,
ioMetrics, tracePool);
this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics,
tracePool) : null;
+ proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
Review comment:
Like I said, I'm fine with relying on RPC threadpool only on the LLAP daemon
side. I'm not talking about that anymore (you can see I amended that change
already)
What I'm talking about now is HS2 side:
- purge currently will block user side:
https://github.com/szlta/hive/blob/HIVE-22821/ql/src/java/org/apache/hadoop/hive/ql/processors/LlapCacheResourceProcessor.java#L141
- while proactive eviction - I'd propose - should not:
https://github.com/szlta/hive/blob/HIVE-22821/ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java#L79
That's the difference I'm interested in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
