szlta commented on a change in pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389995214
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics,
ioMetrics, tracePool);
this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics,
tracePool) : null;
+ proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
Review comment:
"better to deal with it within HS2 by making this fire and forget kind of
request"
This is exactly my intention and how the code is right now, as you can see
this if you read back and take a look on the code.
"fraction of second"
For one daemon, yes - what if we have many? And how will the remote
invocations' overhead add up to this?
"why it is done on the llap side"
I already stated 2 times that I'm fine and agree with you on not doing
anything additional async stuff on LLAP daemon side, btw did you not see this
commit in this PR?
https://github.com/apache/hive/pull/909/commits/ebf39c472dd311e9b7b3d93061736fcac3e20240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
