b-slim commented on a change in pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389826419
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics,
ioMetrics, tracePool);
this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics,
tracePool) : null;
+ proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
Review comment:
I do think you see my point, by adding this new pool what are you actually
unlocking/unclocking ?
Which Threads/actors are blocked and how this is helping?
When you say HS2, can you explain what is blocked there and how that have an
impact on the system ?
What am trying to say is that there is nothing to really unblock and this is
adding some code that is not needed IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
