marton-bod commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r666236787
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
##########
@@ -257,6 +258,16 @@ default boolean supportsPartitionTransform() {
return false;
}
+ /**
+ * Return the partition transform specification table property key together
with the specification value in json
Review comment:
nit: I don't think we need to mandate that the value is in json format.
Some other handlers could choose a different format in the future. Since the
return type is just a string that'll be plugged into the output, there's no
reason to have this restriction I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
