lcspinter commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r666678405
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -270,6 +270,15 @@ public boolean supportsPartitionTransform() {
return true;
}
+ @Override
+ public Map<String, String>
getPartitionTransformSpecProperty(org.apache.hadoop.hive.ql.metadata.Table
hmsTable) {
+ Map<String, String> property = new HashMap<>();
+ TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
+ Table table = Catalogs.loadTable(conf, tableDesc.getProperties());
Review comment:
The iceberg table is only loaded once, so changing the call to
`IcebergTableUtil#getTable()` doesn't add much value at the moment. But I
guess, we should consider that this might change in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
