lcspinter commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r667892099
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
In this case, the partition spec will be among the table properties.
I've added a new test case to cover this as well.
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Sorry, my bad, I've slipped over the `PARTITIONED BY` part. This will
be the output:
`CREATE TABLE tbl (a int, b int) PARTITIONED BY SPEC(c) STORED BY ICEBERG`
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
My example was incorrect :), but the actual output will contain the
additional column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
