marton-bod commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r667818010
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Do we know what happens when we use the "old" partition syntax for
identity transforms?
`CREATE TABLE tbl (a int, b int) STORED BY ICEBERG PARTITIONED BY (c string)`
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
sorry, I probably wasn't clear, I meant to ask about the `PARTITIONED BY
(c string)` syntax (which creates a single, identity transform partition). But
also testing the json property is a good call too.
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Great!
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Although...on second thought that won't produce a syntactically correct
statement right? because we'd need to `c string` to be in the column
definitions then like this:
```
CREATE TABLE tbl (a int, b int, c string) PARTITIONED BY SPEC(c) STORED BY
ICEBERG
```
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Great :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
