pvary commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r873492496
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergTimeTravel.java:
##########
@@ -36,15 +34,19 @@ public class TestHiveIcebergTimeTravel extends
HiveIcebergStorageHandlerWithEngi
@Test
public void testSelectAsOfTimestamp() throws IOException,
InterruptedException {
- Table table = prepareTableWithVersions(2);
+ Table table = testTables.createTableWithVersions(shell, "customers",
+ HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA,
+ fileFormat, HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS, 2);
List<Object[]> rows = shell.executeStatement(
- "SELECT * FROM customers FOR SYSTEM_TIME AS OF '" +
timestampAfterSnapshot(table, 0) + "'");
+ "SELECT * FROM customers FOR SYSTEM_TIME AS OF '" +
+ HiveIcebergTestUtils.timestampAfterSnapshot(table, 0) + "'");
Review Comment:
nit: maybe static import the method, and then there is less code and code
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
