marton-bod commented on code in PR #3287: URL: https://github.com/apache/hive/pull/3287#discussion_r873772303
########## parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g: ########## @@ -214,6 +214,7 @@ TOK_ALTERTABLE_ADDCONSTRAINT; TOK_ALTERTABLE_UPDATECOLUMNS; TOK_ALTERTABLE_OWNER; TOK_ALTERTABLE_SETPARTSPEC; +TOK_ALTERTABLE_ROLLBACK; Review Comment: Have you considered making the function name a parameter instead of a keyword? e.g. `ALTER TABLE tbl EXECUTE 'rollback'` This could provide the flexibility of the stored procedures used in Spark, allowing you to reuse the syntax for the other operations (expire_snapshot, rewrite_manifests, etc) in the future. The storage handler could specify which exact 'stored procedures' it supports, and throw an exception if it's unsupported for the table type. Just an idea, let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
