lcspinter commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r879508204
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -425,6 +425,15 @@ public void
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
case SETPARTITIONSPEC:
IcebergTableUtil.updateSpec(conf, icebergTable);
break;
+ case ROLLBACK:
+ LOG.info("Executing rollback operation on iceberg table. If you
would like to revert rollback you could " +
Review Comment:
Yes and no :)
Iceberg rollback creates a new snapshot, but it also keeps the historical
evolution. It is easier to understand through an example.
Lets have the following snapshots:
A -> B -> C -> D
After a rollback to let's say B, the snapshot chain will look like
A -> E
where E will be a new snapshot, but all it's properties (except for the ID)
will match B snapshot's properties.
So from this point, If I would like to rollback to D, I would get an
exception since D is not an ancestor of E.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
