lcspinter commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r879553047


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -184,4 +186,27 @@ public static void updateSpec(Configuration configuration, 
Table table) {
   public static boolean isBucketed(Table table) {
     return table.spec().fields().stream().anyMatch(f -> 
f.transform().toString().startsWith("bucket["));
   }
+
+  /**
+   * Roll an iceberg table's data back to a specific snapshot identified 
either by id or before a given timestamp.
+   * @param configuration a Hadoop configuration
+   * @param table the iceberg table
+   */
+  public static void rollback(Configuration configuration, Table table) {
+    RollbackSpec rollbackSpec = SessionStateUtil.getResource(configuration, 
hive_metastoreConstants.ROLLBACK_SPEC)

Review Comment:
   Compaction is a different animal. Directly passes the compaction type 
parameter to the HMS client, which will store everything in the HMS db 
compaction queue.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to