rbalamohan commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r974755315
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java:
##########
@@ -176,10 +179,27 @@ public boolean shouldSkipCombine(Path path, Configuration
conf) {
}
@Override
- public VectorizedSupport.Support[] getSupportedFeatures() {
+ public VectorizedSupport.Support[] getSupportedFeatures(HiveConf hiveConf,
Set<String> tableNames) {
// disabling VectorizedSupport.Support.DECIMAL_64 as Parquet doesn't
support it, and we have no way of telling
// beforehand what kind of file format we're going to hit later
- return new VectorizedSupport.Support[]{ };
+ boolean onlyOrcFiles = true;
+ try {
+ Hive hiveDb = Hive.get(hiveConf, false);
Review Comment:
Is it possible to make this decision in
Vectorizer::getVectorizedInputFormatSupports? Basically trying to avoid the
mixup of HMS related information in InputFormats, as they will be used in
AppMasters and tasks. I agree that getSupportedFeatures will be called mainly
during compilation, but it will be good to keep HMS interactions outside of
inputformats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
