abstractdog commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r976692639
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -826,6 +834,18 @@ private Type.PrimitiveType
getPrimitiveTypeOrThrow(FieldSchema field) throws Met
return (Type.PrimitiveType) newType;
}
+ private void setOrcOnlyFilesParam(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
+ if
(org.apache.iceberg.FileFormat.ORC.name().equalsIgnoreCase(hmsTable.getSd().getInputFormat())
||
Review Comment:
nit: what about refactoring this huge condition to a method? (it can be even
reused later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
