ayushtkn commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r975489411


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java:
##########
@@ -176,10 +179,27 @@ public boolean shouldSkipCombine(Path path, Configuration 
conf) {
   }
 
   @Override
-  public VectorizedSupport.Support[] getSupportedFeatures() {
+  public VectorizedSupport.Support[] getSupportedFeatures(HiveConf hiveConf, 
Set<String> tableNames) {
     // disabling VectorizedSupport.Support.DECIMAL_64 as Parquet doesn't 
support it, and we have no way of telling
     // beforehand what kind of file format we're going to hit later
-    return new VectorizedSupport.Support[]{  };
+    boolean onlyOrcFiles = true;
+    try {
+      Hive hiveDb = Hive.get(hiveConf, false);

Review Comment:
   Thanx Rajesh, I have changed it. Just a bit of hardcoding required for the 
iceberg related stuff, since hive-exec doesn't have iceberg dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to