abstractdog commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r976709923
##########
iceberg/iceberg-handler/src/test/results/positive/alter_table_to_iceberg.q.out:
##########
@@ -103,6 +103,7 @@ Table Parameters:
metadata_location hdfs://### HDFS PATH ###
numFiles 1
numRows 5
+ orc.files.only false
Review Comment:
I'm not sure if I get the intention of orc.files.only property, but tbl_orc
clearly looks like an orc table, isn't it the case? I can see that it has no
partitions (so I cannot imagine how can we store other data in other formats
here)
so if orc.files.only evaluates to false, we'll miss vectorization
opportunity, right?
##########
iceberg/iceberg-handler/src/test/results/positive/alter_table_to_iceberg.q.out:
##########
@@ -103,6 +103,7 @@ Table Parameters:
metadata_location hdfs://### HDFS PATH ###
numFiles 1
numRows 5
+ orc.files.only false
Review Comment:
I'm not sure if I get the intention of "orc.files.only" property, but
tbl_orc clearly looks like an orc table, isn't it the case? I can see that it
has no partitions (so I cannot imagine how can we store other data in other
formats here)
so if orc.files.only evaluates to false, we'll miss vectorization
opportunity, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
