dengzhhu653 commented on code in PR #4194:
URL: https://github.com/apache/hive/pull/4194#discussion_r1171297701


##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2769,6 +2802,11 @@ PartitionsResponse 
get_partitions_req(1:PartitionsRequest req)
   GetPartitionsByNamesResult 
get_partitions_by_names_req(1:GetPartitionsByNamesRequest req)
                         throws(1:MetaException o1, 2:NoSuchObjectException o2)
 
+    // retrieve properties
+    PropertyGetResponse get_properties(1:PropertyGetRequest req);

Review Comment:
   Should we declare the throwing exception of these two methods? I'm afraid 
the Thrift would throw transport exception instead when things go wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to