saihemanth-cloudera commented on code in PR #4194: URL: https://github.com/apache/hive/pull/4194#discussion_r1171892570
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/HMSPropertyManager.java: ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore.properties; + +import org.apache.hadoop.hive.metastore.api.MaintenanceOpStatus; +import org.apache.hadoop.hive.metastore.api.MaintenanceOpType; + +import java.util.Map; +import java.util.Objects; +import java.util.TreeMap; + +/** + * A property manager tailored for the HiveMetaStore. + * It describes properties for cluster, database and table based on declared schemas. + * A property is of the form: + * <ul> + * <li>name : when it refers to a cluster property named 'name'</li> + * <li>db.name : when it refers to a database property named 'name' for the database 'db'</li> + * <li>db.table.name : when it refers to a table property named 'name' for the table 'table' in the database 'db</li> + * </ul> + */ +public class HMSPropertyManager extends PropertyManager { + private static final String CLUSTER_PREFIX = "cluster"; + private static final String DATABASE_PREFIX = "database"; + private static final String TABLE_PREFIX = "table"; + /* Declare HMS. */ + static { + PropertyManager.declare("hms", HMSPropertyManager.class); + } + + /** + * Maintenance Operation Type. + */ + public static final PropertyType<MaintenanceOpType> MAINTENANCE_OPERATION = new PropertyType<MaintenanceOpType>("MaintenanceOperation"){ Review Comment: nit: space between `){` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
