saihemanth-cloudera commented on code in PR #4194:
URL: https://github.com/apache/hive/pull/4194#discussion_r1171695068
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -5192,4 +5192,25 @@ public List<WriteEventInfo>
getAllWriteEventInfo(GetAllWriteEventInfoRequest req
public AbortCompactResponse abortCompactions(AbortCompactionRequest request)
throws TException{
return client.abort_Compactions(request);
}
+
+ @Override
+ public boolean setProperties(String nameSpace, Map<String, String>
properties) throws TException {
+ PropertySetRequest psr = new PropertySetRequest();
+ psr.setNameSpace(nameSpace);
+ psr.setPropertyMap(properties);
+ return client.set_properties(psr);
+ }
+
+ @Override
+ public Map<String, Map<String, String>> getProperties(String nameSpace,
String mapPrefix, String mapPredicate, String... selection) throws TException {
+ PropertyGetRequest request = new PropertyGetRequest();
+ request.setNameSpace(nameSpace);
+ request.setMapPrefix(mapPrefix);
+ request.setMapPredicate(mapPredicate);
+ if (selection != null && selection.length > 0) {
+ request.setMapSelection(Arrays.asList(selection));
+ }
+ PropertyGetResponse response = client.get_properties(request);
Review Comment:
should we do this instead `return
client.get_properties(request).getProperties()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
