saihemanth-cloudera commented on code in PR #4194:
URL: https://github.com/apache/hive/pull/4194#discussion_r1171701352
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -4393,4 +4393,27 @@ ReplicationMetricList
getReplicationMetrics(GetReplicationMetricsRequest
AbortCompactResponse abortCompactions(AbortCompactionRequest request) throws
TException;
+ /**
+ * Sets properties.
+ * @param nameSpace the property store namespace
+ * @param properties a map keyed by property path mapped to property values
+ * @return true if successful, false otherwise
+ * @throws TException
+ */
+ default boolean setProperties(String nameSpace, Map<String, String>
properties) throws TException {
+ throw new UnsupportedOperationException();
Review Comment:
I think this definition is incorrect. We should only declare the method here
and any other dummy clients or clients that don't support this method should
define this as unsupported.
Currently, SessionHiveMetaStoreClient would throw this exception. Can you
please implement these methods in SessionHiveMetastoreClient as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
