scarlin-cloudera commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1706994848
@ayushtkn If it turns out it is hard to put it all in one statement, it's probably not going to get done anytime soon. I believe this is the case. In that case, we have two choices: 1) Abandon the patch and do nothing. In which case, we have a status quo of semi-colons on the alter statement but none on the first statement. That's a little yucky and heinous in my opinion since that causes a headache on a cut and paste of the show command. 2) Put no semi-colon if there is only one statement and all semi-colons on all statements. This is something you sorta agreed to before and, imo, is definitely better than 1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
