jfsii commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1694004798
I think putting the semicolon everywhere is the best decision. I think the concerns about backwards compatibility are a bit overblown. If someone somewhere is taking SHOW CREATE output and passing it to driver directly I would be surprised (though I've been surprised before). As for not adding it to just the last line output, that seems to me to needlessly complicate this in the interest of compromise with no real up side. The other option I could possibly buy-in to is no semicolons everywhere, but I think I'd rather optimize for the copy paste pattern then what I would guess is the less likely passing directly to a driver use case (I do think some other systems - do not put the semi colons but they also do not emit multiple SQL statements in the output). Either way in the end it should be consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
