scarlin-cloudera commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1692641184
I think leaving the semi-colon off of the last query statement is a good compromise between keeping backward compatibility and fixing this issue. Most people probably don't use constraints and therefore only have the one statement when they do a "show create table". So they wouldn't have any regression from their current way of doing things. If they did have constraints, I doubt they were parsing all the statements to insert the missing semi-colon after the create table. If they did, they should have reported it as a bug instead of hacking around it. So I think leaving a semi-colon off of the last "alter add constraint" statement works while adding the semi-colon after the "create table" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
