jfsii commented on PR #4620: URL: https://github.com/apache/hive/pull/4620#issuecomment-1701542126
@ayushtkn I feel like this a bit of a bike shedding argument at this point. I think everyones opinions on this topic is valid in one way or another and will back the consensus view. I think @zabetak's opinion here would be good (and may be different than my opinion) and a nice tie breaker. > Considering nobody has use case for such a old behaviour is like "only we use the product" and we are ok with it and this is against the spirit of opensource. I did not mean to suggest anything remotely what you imply with this statement. I just stated that I feel the concerns about backwards compatibility in this specific area are likely overblown in my opinion. I can not see how my statement and participation in this discussion would be considered against the "spirit of open-source" - if anything I would consider it an example of the spirit of open source. When are we allowed to break compatibility? We are in the middle of a release push for 4.0.0. I would think breaking compatibility for something like this, now would be a good time. Anything we do that is not a new feature changes behavior/compatibility and you could use the same argument against any change (Though I do tend to agree in general, that needlessly changing things that break compatibility is undesirable). I think consistency is important - otherwise you have to handle both cases as an end user. My vote is either to always have the semi-colons or never have them. I lean towards having them, but I can see the other way as a good choice too (not having them at all). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
